Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor save state handler #800

Merged
merged 7 commits into from
Apr 1, 2024
Merged

Refactor save state handler #800

merged 7 commits into from
Apr 1, 2024

Conversation

mbraak
Copy link
Owner

@mbraak mbraak commented Apr 1, 2024

No description provided.

Copy link

codecov bot commented Apr 1, 2024

Bundle Report

Changes will decrease total bundle size by 79 bytes ⬇️

Bundle name Size Change
jqtree-bundle-jqtree 50.81kB 79 bytes ⬇️

Copy link

github-actions bot commented Apr 1, 2024

Size Change: -49 B (0%)

Total Size: 28.5 kB

Filename Size Change
./lib/saveStateHandler.js 1.5 kB -49 B (-3%)
ℹ️ View Unchanged
Filename Size
./lib/dataLoader.js 861 B
./lib/dragAndDropHandler/dragElement.js 437 B
./lib/dragAndDropHandler/generateHitAreas.js 1.21 kB
./lib/dragAndDropHandler/index.js 2.2 kB
./lib/dragAndDropHandler/iterateVisibleNodes.js 551 B
./lib/dragAndDropHandler/types.js 33 B
./lib/elementsRenderer.js 1.82 kB
./lib/jqtreeMethodTypes.js 33 B
./lib/jqtreeOptions.js 33 B
./lib/keyHandler.js 738 B
./lib/mouseHandler.js 1.47 kB
./lib/mouseUtils.js 229 B
./lib/node.js 3.22 kB
./lib/nodeElement/borderDropHint.js 386 B
./lib/nodeElement/folderElement.js 915 B
./lib/nodeElement/ghostDropHint.js 529 B
./lib/nodeElement/index.js 738 B
./lib/nodeUtils.js 194 B
./lib/position.js 384 B
./lib/scrollHandler.js 471 B
./lib/scrollHandler/containerScrollParent.js 874 B
./lib/scrollHandler/createScrollParent.js 521 B
./lib/scrollHandler/documentScrollParent.js 1.05 kB
./lib/scrollHandler/types.js 33 B
./lib/selectNodeHandler.js 684 B
./lib/simple.widget.js 947 B
./lib/tree.jquery.js 5.96 kB
./lib/util.js 348 B
./lib/version.js 147 B

compressed-size-action

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 94.06%. Comparing base (9826a2e) to head (6ab54ee).

❗ Current head 6ab54ee differs from pull request most recent head aef5cd4. Consider uploading reports for the commit aef5cd4 to get more accurate results

Files Patch % Lines
src/saveStateHandler.ts 84.61% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #800      +/-   ##
==========================================
+ Coverage   93.60%   94.06%   +0.46%     
==========================================
  Files          30       30              
  Lines        2314     2309       -5     
  Branches      593      591       -2     
==========================================
+ Hits         2166     2172       +6     
+ Misses        148      137      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbraak mbraak merged commit c7b325c into dev Apr 1, 2024
4 checks passed
@mbraak mbraak deleted the refactor-save-state-handler branch April 1, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant