Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline editing feature #29

Closed
mbrn opened this issue Aug 14, 2018 · 10 comments
Closed

Add inline editing feature #29

mbrn opened this issue Aug 14, 2018 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@mbrn
Copy link
Owner

mbrn commented Aug 14, 2018

Add inline editing feature

@mbrn mbrn added the enhancement New feature or request label Aug 14, 2018
@mbrn mbrn self-assigned this Aug 14, 2018
@mbrn mbrn added this to the v1.7.0 milestone Oct 25, 2018
@jakeleventhal
Copy link

Any update on when this will be added?

@mbrn
Copy link
Owner Author

mbrn commented Nov 15, 2018

@jakeleventhal

I can't promise any date to close these issues. But i will do all them as soon as possible.

@jakeleventhal
Copy link

jakeleventhal commented Nov 21, 2018

I think that what would make this great would be if you could edit by clicking on a column rather than editing an entire row at once. Or at the very least allow actions to be created on any column via an onClick parameter

@mbrn
Copy link
Owner Author

mbrn commented Nov 21, 2018

I aggre with your opinion. When user click on the edit button, the row's data would replace with edit components and a submit button.

@jakeleventhal
Copy link

I feel like it’d be cleaner to just have the “submit” button not exist. Instead, you could specify an onBlur which would submit after clicking away or pressing the enter key

@mbrn
Copy link
Owner Author

mbrn commented Nov 21, 2018

Maybe, i will think about it

@jakeleventhal
Copy link

Something that needs to be in this issue is the ability to have a callback function.

so that the user can write code after the cell has been edited.

@urirahimi
Copy link

Hi @mbrn is there any update on this feature?

@mbrn
Copy link
Owner Author

mbrn commented Jan 1, 2019

Hi @urirahimi ,

Firstly i will resolve #135. After resolving #135 i can look at this.

@mbrn mbrn closed this as completed in 8610d90 Mar 12, 2019
@mbrn
Copy link
Owner Author

mbrn commented Mar 12, 2019

This is done with 1.23.0

PavelS111 added a commit to PavelS111/material-table that referenced this issue May 23, 2019
PavelS111 added a commit to PavelS111/material-table that referenced this issue May 23, 2019
PavelS111 added a commit to PavelS111/material-table that referenced this issue May 23, 2019
FalkF pushed a commit to FalkF/material-table that referenced this issue Jan 18, 2021
…s-to-functional-component

converted MTableCell class component to functional component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants