Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUI 5 compatibility #2542

Closed
wants to merge 15 commits into from
Closed

MUI 5 compatibility #2542

wants to merge 15 commits into from

Conversation

villuv
Copy link

@villuv villuv commented Oct 12, 2020

Description

Work for Material UI 5 compatibility as there are some things renamed.

Impacted Areas in Application

List general components of the application that this PR will affect:

  • Pagination
  • Theming
  • Dependencies

Additional Notes

This PR can be kept open at this moment, as there probably will be more breaking changes in MUI 5 coming.

@villuv villuv requested a review from mbrn as a code owner October 12, 2020 14:55
@bneigher
Copy link

#2556

@villuv
Copy link
Author

villuv commented Oct 26, 2020

I will try to migrate this also to material-ui-pickers 4.0.0-alpha.12 as it will also be merged to MUI core soon.

@villuv
Copy link
Author

villuv commented Oct 26, 2020

As material-pickers' LocalizationProvider (previously known as MuiPickersUtilsProvider) will very likely be moved to MUI core as general purpose locale configuration provider, I suggest removing extra LocalizationProvider wrapper and its configuration from here and respect provider set by enclosing application. In case users need to override localization of one particular table instance, they could always wrap that particular instance with specific LocalizationProvider

@villuv
Copy link
Author

villuv commented Nov 14, 2020

material-pickers is now migrated to @material-ui/lab

@villuv
Copy link
Author

villuv commented Nov 26, 2020

Hi, @mbrn
I don't really understand if the failing check is caused by me or is it something wrong with the pipeline.

  • Thanks

@bneigher
Copy link

for those of us (an increasing population) of people who have upgraded to MUI 5 - this is a real pain in the butt! Can we get this merged?

@villuv
Copy link
Author

villuv commented Dec 16, 2020

for those of us (an increasing population) of people who have upgraded to MUI 5 - this is a real pain in the butt! Can we get this merged?

According to README, @mbrn is probably not going to merge this before refactoring is done, even though I can't seem to find a branch where refactoring work is going on, it's probably private for some reason. On the other hand MUI 5 is still currently very alpha and breaking changes are coming in every couple of weeks, so merging this into master is probably not a good idea anyway before it gets stabilized (say, beta)

As I am one of the people with a painful butt, I mainly keep this PR up for tracking my work and in case someone finds it useful too. If it is any use for material-table in general, is up to maintainer's to decide. That said, I'd be glad to hear some comments from them.

Edit: typo

@bneigher
Copy link

but why not have a @next branch and push tags on that

@villuv
Copy link
Author

villuv commented Dec 17, 2020

but why not have a @next branch and push tags on that

I don't know. This is up to maintainers to decide. I'm just another user trying to help the project that I like...

@stale
Copy link

stale bot commented Mar 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required.

@stale stale bot added the wontfix This will not be worked on label Mar 17, 2021
@stale stale bot removed the wontfix This will not be worked on label Mar 18, 2021
superyhee
superyhee previously approved these changes May 15, 2021
@dan1elok
Copy link

Thanks for the contribution. It saved the day!

@iamchathu
Copy link

Any update on this?

@villuv
Copy link
Author

villuv commented Sep 20, 2021

Any update on this?

It has been quiet here. But basically the same PR got merged to 'next' branch of this: https://github.com/material-table-core/core/tree/next which is a community fork of this repo and it has more active development. At least I'm in process of migrating our projects to that fork.

@stale
Copy link

stale bot commented Dec 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required.

@stale stale bot added the wontfix This will not be worked on label Dec 19, 2021
@stale stale bot closed this Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants