-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MUI 5 compatibility #2542
MUI 5 compatibility #2542
Conversation
I will try to migrate this also to material-ui-pickers 4.0.0-alpha.12 as it will also be merged to MUI core soon. |
As material-pickers' |
material-pickers is now migrated to |
Hi, @mbrn
|
for those of us (an increasing population) of people who have upgraded to MUI 5 - this is a real pain in the butt! Can we get this merged? |
According to README, @mbrn is probably not going to merge this before refactoring is done, even though I can't seem to find a branch where refactoring work is going on, it's probably private for some reason. On the other hand MUI 5 is still currently very alpha and breaking changes are coming in every couple of weeks, so merging this into master is probably not a good idea anyway before it gets stabilized (say, beta) As I am one of the people with a painful butt, I mainly keep this PR up for tracking my work and in case someone finds it useful too. If it is any use for material-table in general, is up to maintainer's to decide. That said, I'd be glad to hear some comments from them. Edit: typo |
but why not have a @next branch and push tags on that |
I don't know. This is up to maintainers to decide. I'm just another user trying to help the project that I like... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required. |
Thanks for the contribution. It saved the day! |
Any update on this? |
It has been quiet here. But basically the same PR got merged to 'next' branch of this: https://github.com/material-table-core/core/tree/next which is a community fork of this repo and it has more active development. At least I'm in process of migrating our projects to that fork. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required. |
Description
Work for Material UI 5 compatibility as there are some things renamed.
Impacted Areas in Application
List general components of the application that this PR will affect:
Additional Notes
This PR can be kept open at this moment, as there probably will be more breaking changes in MUI 5 coming.