Fix for 772 and 773

[mbround18]

Description

Contributions

• Fixes AppID Changed #772
• Fixes Execing into docker fails with odin commands #773
• QOL, uses steam user as base user in final container
• QOL, correctly sets the home directory and working directory of the containers
• QOL, uses common utils shell script for both script files. following DRY format.

Checklist

• I added one or multiple labels which best describes this PR.
• I have tested the changes locally.
• This PR has a reviewer on it.
• I have validated my changes in a docker container and on Ubuntu. (Only needed for Odin or Docker Changes)

[FooDeas]

Build logs of d243267:
log-build_odin.txt
log-build_valheim.txt

[mbround18]

:

Those look like successful logs, have you tried running the game server?

[mbround18]

Found a new funny one, server only launches with old app id but old app id is dead. So i switch the app id right before launch. building canary now to test

[mbround18]

Can confirm my server shows up in server browser

[FooDeas]

I'm trying again with cd15943.

[mbround18]

I see server in ingame browser too with status

[FooDeas]

cd15943 starts now! But entering the console with gosu (and maybe the cronjob?) doesn't work:

steam@295714bb5ba6:~/valheim$ /usr/sbin/gosu steam /bin/bash /home/steam/scripts/auto_update.sh
error: failed switching to "steam": operation not permitted

There is another problem with the updater now:

steam@295714bb5ba6:~/valheim$ odin update
[ODIN][INFO]  - Checking for updates
thread 'main' panicked at src/odin/server/process.rs:38:10:
Failed to get process exe
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[mbround18]

thread 'main' panicked at src/odin/server/process.rs:38:10:

You shouldnt need gosu anymore, just exec into the container and it takes you in as steam user

[mbround18]

Alright @FooDeas it was some formatting issues with the manifests, i fixed the brittleness with some regex. Arguably just as brittle but its the only option for right now. Sadly steam doesnt output json.

670f365 should be good to go :)

[FooDeas]

You shouldnt need gosu anymore, just exec into the container and it takes you in as steam user

That's what I thought and did. But there is the cron setup in the entrypoint.sh that won't work anymore.

[mbround18]

@FooDeas this line sets the cron script as root, the gosu should still work for the crons. ill setup some crons for tonight and let em run

[FooDeas]

Right. I thought from the wrong user context.

[mbround18]

You were right on the call out! im reworking the cron system rn

[FooDeas]

Interesting. I was confused by the "sudo tee" statements writing the cron files. Based on this, I wrongly concluded that it is now in the Steam user context. After your hint, I also would have expected that there would be no problems. 😮

[mbround18]

Alrrirght @FooDeas thiissssss should work :) all features tested locally

[FooDeas]

Looks good! I can test it and give you feedback tomorrow, if you want.

[FooDeas]

It now works without any problems!