-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
It was unnecessary, it comes bundled with LuaSocket
Use BitOps library where available
Added optional args argument to init, args are the arguments passed to love.load. Used to get the credentials passed by Quick Play
A function to parse the gjapi_credentials.txt file generated by Quick Play, some other minor changes
More info passed to the developer in order to determine possible errors
Basic cache for trophies
fixed some minor bugs, and fixed setData, now it uses POST requests
A mistake I made in the last commit sorry
Fixed #9 too, sorry I made a mistake in the last commit and commited two files that werent part of your project, I have already deleted them. If you want I can start a new Pull request with just one commit, I think that 9 commits is a little too much for the minor changes I made. |
Format URL and data values to escape especial character where needed
Now it's the same as the current master branch in kikito's repo
Whoa. You did such a great work.
|
@insweater
I think there a lot of commits here, and this whole pull requests should be cherry picked or rebased. Especially because of this commit that was made in error |
function GJ.getCredentials(dir)
local f = io.open(dir.."gjapi-credentials.txt")
if f then
GJ.username = f:read()
GJ.userToken = f:read()
return true
else
return false
end
end You would call it like this in LÖVE GJ.getCredentials(love.filesystem.getWorkingDirectory().."/") I know that there are too many commits, I want to make all the changes, delete my repo and create it again, then submit all the changes in one commit, I want to know if you consider any of the changes is not good like you did here |
Okey I checked, there are two cases where I really deleted the And the |
If you to remove http.lua from repo, shall we also remove md5.lua? |
So long as the dependency is easily identified and linked, I see no problem in removing |
Yeah, and in installation you write that Should I create a new PR with all this changes? |
That would be pretty nice. |
new PR in the way |
Fixes issues #1, #2, #4 and #6