Fix testing example in README #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example for tests is incorrect and does not compile because the `to` field must be an array of strings. As it stands the example will result in an error `cannot unmarshal string into Go struct field Message.tests.messages.to of type []string`.
|
Good catch! Thanks for the fix Nick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example for tests is incorrect and does not compile because the
tofield must be an array of strings. As it stands the example will result in an errorcannot unmarshal string into Go struct field Message.tests.messages.to of type []string.Thanks for a super valuable piece of software! I'm loving Gmailctl.