Parse signs config and store info in state to be used in group filter

[bfauble]

Summary of changes

Asana Ticket: Parse config and store info in state

• Moves state logic into correct namespace
• Parser for parsing signs config feed
• Group filter uses data from state
• TODO: Supervisor to do the actual fetching of feed to feed into state

[github-actions]

Coverage of commit cbad0d2

Summary coverage rate:
  lines......: 92.8% (1453 of 1565 lines)
  functions..: 80.9% (474 of 586 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/filter/suppress/stop_prediction_status.ex         | 100%     19| 100%     6|    -      0
  lib/concentrate/group_filter/suppress_stop_time_update.ex         |86.7%     15|75.0%     4|    -      0
  lib/concentrate/parser/signs_config.ex                            | 100%      6| 100%     2|    -      0

Download coverage report

[nlwstein]

This might be better-suited to a quick discussion / call, but could we deploy to a dev environment and validate this behavior manually? There's a lot going on here logic-wise, and I think if we both smoke tested it in dev that would be confidence-inducing.

The code itself looks sound syntactically 🙂

[bfauble]

This might be better-suited to a quick discussion / call, but could we deploy to a dev environment and validate this behavior manually? There's a lot going on here logic-wise, and I think if we both smoke tested it in dev that would be confidence-inducing.

The code itself looks sound syntactically 🙂

At the moment at least, this isn't actually hooked up to run in dev/prod.

https://github.com/mbta/concentrate/blob/master/config/config.exs#L78

The next PR will include both uncommenting/enabling all this code as well as using 'live' data from the signs config to better test against. It'd be possible to add some temp commits here to fake using live data, but it would be based on assumed data format vs the actual feeds.

[nlwstein]

OK - that makes sense - I figure we can review this more conclusively once it's enabled in dev @bfauble. The code otherwise looks syntactically good so I think this is good to merge.

[nlwstein]

nit: does this need to be an anonymous function? I think you can just pass an interpolated string directly into Logger.info.

[github-actions]

Coverage of commit 457414b

Summary coverage rate:
  lines......: 92.8% (1453 of 1565 lines)
  functions..: 80.9% (474 of 586 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate/filter/suppress/stop_prediction_status.ex         | 100%     19| 100%     6|    -      0
  lib/concentrate/group_filter/suppress_stop_time_update.ex         |86.7%     15|75.0%     4|    -      0
  lib/concentrate/parser/signs_config.ex                            | 100%      6| 100%     2|    -      0

Download coverage report