-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure ExAws without env vars #1940
Conversation
and remove stale ones
My concern is that this won't work running locally in Docker. My preference would be to create a mock of ExAws and use that locally. Then we could get rid of this configuration altogether. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works pretty slick
config/deps/deps.exs
Outdated
access_key_id: [{:awscli, "default", 30000}], | ||
secret_access_key: [{:awscli, "default", 30000}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes that the configuration being used is the default configuration. This won't work for people for whom these credentials are under another configuration name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, I'll switch it to using the system's via (from ExAws
):
Alternatively, if you already have a profile name set in the AWS_PROFILE environment variable, you can use that with
{:awscli, :system, timeout}
@thecristen pretty sure we don't need this now that we have this working both locally and in docker compose |
Covered elsewhere. |
In the interest of best security practice, we can remove reliance on hardcoded
AWS_ACCESS_KEY_ID
andAWS_SECRET_ACCESS_KEY
environment variables by configuring theExAws
dependency in this particular way! I also did some light updating to associated docs, which includes using AWS CLI.Can the current devs confirm (via approval or comment on this PR) that this setup works on their machines? @kotva006 @anthonyshull @amaisano