Implemented local override config file #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbucc
reviewed
Jun 13, 2018
shmig
Outdated
| # any error in configuration file should cause failure | ||
| # to avoid potential database corruption | ||
| trap 'die "Local configuration failed"' ERR | ||
| source "$LOCAL_CONFIG" |
There was a problem hiding this comment.
Looks like source is a bashism (https://stackoverflow.com/a/11588636/1789168)
Please use . (dot) as that is POSIX.
|
What a great PR, thanks for you efforts! I suggested one small tweak to drop a bashism; see the comment I made in the PR diff. |
|
Haha, that's funny, I actually only used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to specify a local configuration file
shmig.local.confthat they can ignore from version control, such that they may specify instance-specific configs that override the default configs inshmig.conf.This is a scheme I much prefer to environment variables, as there is virtually no devops overhead -- you just add the configs in the local file and any user that runs the program will have access to them.
This can be used to easily implement multiple environments, as you've demonstrated with
prodvstest, among other things.Also, if you haven't seen bash_unit, I've found it to be pretty cool. I didn't use it here because I didn't want to disrupt your test flow, but thought you might like to know :).