This repository has been archived by the owner on May 2, 2022. It is now read-only.
Add Methods for class Client #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc-chinju
reviewed
Nov 12, 2017
| module BitflyerApi | ||
| module Methods | ||
| module Private | ||
| module API |
There was a problem hiding this comment.
The nest is so deep.
I recommend you fix module Bitflyer::Methods::Private::API.
or
module Bitflyer::Methods::Private
module API
end
end
cohki0305
force-pushed
the
add-method
branch
from
294c034
to
4fd5612
Compare
|
Thank you for your coding! 👍 |
|
Thank you for reviewing! I merge this pr. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods
private methods' namespace is named after Bitflyer API documents