LibEvent-based socket API #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmaxoft
force-pushed
the
libevent
branch
6 times, most recently
from
c0fa329
to
4af6e8c
Compare
|
I think this is now ready for a major review - is this API sufficient, does it perform well, and is it documented enough? |
| /** Returns true if the server has been started correctly and is currently listening for incoming connections. */ | ||
| virtual bool IsListening(void) const = 0; | ||
| }; | ||
| typedef SharedPtr<cServerHandle> cServerHandlePtr; |
There was a problem hiding this comment.
Is it really necessary for this to be a shared_ptr rather than a unique_ptr?
There was a problem hiding this comment.
The instance is returned by the cNetwork::Listen() function and is also stored within the cNetworkSingleton class.
|
Shall we merge now and open a new PR for the actual rewrite of the server internals (so that the Lua API can be developed in parallel in a separate PR)? |
|
I agree for a merge. |
|
After reading the |
This is mainly for WinXP and RasPi testing.
avoidss unused variable error in clang
The callback receives the error details.
The link-callbacks for each new accepted link are now received from the OnIncomingConnection listen-callback.
This allows the callback classes to store the link inside them and use it internally later on, mainly for sending data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET!
This is a work-in-progress to implement a LibEvent-based socket API that both the C++ part and Lua plugins could use. The PR has been created as a platform for (early) code review; for discussion please use the forum thread:
http://forum.mc-server.org/showthread.php?tid=1700
Will fix #1352