fix BrewingStand inventory is updated immediately instead of after fi…

…ring the event. Now the event can be canceled correct. (#4351)
mcMMO-Dev · Dec 10, 2020 · 0e09ac3 · 0e09ac3
1 parent c4072ee
commit 0e09ac3
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/main/java/com/gmail/nossr50/skills/alchemy/AlchemyPotionBrewer.java b/src/main/java/com/gmail/nossr50/skills/alchemy/AlchemyPotionBrewer.java
@@ -114,6 +114,7 @@ public static void finishBrewing(BlockState brewingStand, Player player, boolean
         }
 
         List<AlchemyPotion> inputList = new ArrayList<>();
+        ItemStack[] outputList = new ItemStack[3];
 
         for (int i = 0; i < 3; i++) {
             ItemStack item = inventory.getItem(i);
@@ -128,7 +129,7 @@ public static void finishBrewing(BlockState brewingStand, Player player, boolean
             inputList.add(input);
 
             if (output != null) {
-                inventory.setItem(i, output.toItemStack(item.getAmount()).clone());
+                outputList[i] = output.toItemStack(item.getAmount()).clone();
             }
         }
 
@@ -139,6 +140,12 @@ public static void finishBrewing(BlockState brewingStand, Player player, boolean
             return;
         }
 
+        for (int i = 0; i < 3; i++) {
+            if(outputList[i] != null) {
+                inventory.setItem(i, outputList[i]);
+            }
+        }
+
         removeIngredient(inventory, player);
 
         for (AlchemyPotion input : inputList) {