Fishing shake percentage seems off.

[andrewkm]

Using 2.1.113 compiled on 406429f

At max rank, chance is 56%
https://i.imgur.com/zItFapn.png
Where is this 56% number even coming from... am I missing something?

Advanced.yml

    Fishing:

        ShakeChance:
            Rank_1: 15.0
            Rank_2: 15.0
            Rank_3: 25.0
            Rank_4: 35.0
            Rank_5: 45.0
            Rank_6: 55.0
            Rank_7: 65.0
            Rank_8: 75.0

Wiki states 75% as well:
https://mcmmo.fandom.com/wiki/Fishing

[andrewkm]

In depth test:
Default paper, default mcMMO and not even a permissions plugin, straight up following mcmmo's plugin.yml

<fishing level>:<shake chance>
124:0%
125:0%
250:2%
350:6%
400:6%
800:30%
1000:56%
5000:56%
1000000:56%

https://i.imgur.com/JtoEc97.png
Conclusion: It's definitely an mcMMO bug.

[nossr50]

There's some unused settings in the config, with that said, I'll investigate and see what is going on.

[andrewkm]

Any updates on this one @nossr50

[Lyther]

Spotted this problem in the source code.

The fishing skill uses RandomChanceStatic to calculate the chances. However, this class has a mistaken definition with probabilityCap = XPos. After calculation in getChanceOfSuccess, the value probabilityCap is put into maxProbability. Leads to result formula chance = XPos * (XPos / 100.0D).

This explains why the bug gives chance definition ^ 2 / 100 as a result.

Fixed this problem in my pull request.

[andrewkm]

@Lyther @nossr50
The above commit did not fix the issue.
Instead, fishing shake is now ALWAYS stuck to 30% regardless of your level.
It unlocks at level 250 and simply never increases, whether your fishing level 1000, level 10,000, etc.

The above PR broke it even more.

[Lyther]

@Lyther @nossr50 The above commit did not fix the issue. Instead, fishing shake is now ALWAYS stuck to 30% regardless of your level. It unlocks at level 250 and simply never increases, whether your fishing level 1000, level 10,000, etc.

The above PR broke it even more.

The problem is in the new version of McMMO. With the percentage of shake comes to a fixed value of 30% and here's in the advanced.yml

        ShakeChance:
            Rank_1: 30

And here's in skillranks.yml

    Shake:
        Standard:
            Rank_1: 15
        RetroMode:
            Rank_1: 150

Thought the author has changed the definition of shake skill and makes it a fixed value (just like the IceFishing and other un-upgradable skills).

I haven't touched those files in my pull request.

[nossr50]

I'll adjust Shake to scale and gain ranks again, still getting over my cold

[andrewkm]

Thanks,
Would be much appreciated!

[andrewkm]

@nossr50 unsure if this was forgotten, but it's still an issue on our server.
Any plans on this? Shake continues to be capped at 30%.

Still happening to this date on Paper 1.20.1 and latest mcMMO.

[andrewkm]

Fixed. :)