Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strobo preview improvements #696

Closed
mcallegari opened this issue Nov 24, 2015 · 3 comments
Closed

Strobo preview improvements #696

mcallegari opened this issue Nov 24, 2015 · 3 comments

Comments

@mcallegari
Copy link
Owner

I'm opening this as a reminder, for who wants to pick up this task.
Sooner or later this has to be done anyway, cause I want to have a reliable preview in QLC+ 5.

The changes have to start from the ground up. The involved components are:

  1. Fixture Editor: a Shutter channel should expose the following capabilities:
  • shutter open
  • shutter close
  • specific frequency
  • frequency range
    If the frequencies are not specified in the fixture manual, and instead there is something like "Strobe (slow to fast)" I would say the default behaviour should be an implicit range of 1Hz to 10Hz
  1. QLCCapability class: likewise the color/resource properties we could add:
  • shutterType: Enum { Close, Open, Fixed, Range }
  • shutterMinFreq
  • shutterMaxFreq
    In case of Open/Close the Freq variables will be ignored
    In case of Fixed, shutterMinFreq will be used and shutterMaxFreq will be ignored
  1. 2D Monitor: when we have all the information we need in a QLCCapability, then the monitor will be easy to implement, as long as every FixtureItem has a QTimer to handle the strobe frequency
@janosvitok
Copy link
Contributor

  1. partially fixed: cf58886 (added strobing timer using currently available info)

@janosvitok
Copy link
Contributor

@mcallegari
Copy link
Owner Author

This can finally be closed. Addressed with #1026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants