Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB Matrix with generic dimmers #827

Closed
mcallegari opened this issue Mar 13, 2016 · 0 comments · Fixed by #902
Closed

RGB Matrix with generic dimmers #827

mcallegari opened this issue Mar 13, 2016 · 0 comments · Fixed by #902
Assignees

Comments

@mcallegari
Copy link
Owner

mcallegari commented Mar 13, 2016

Opening this so it doesn't get forgotten
As explained by @janosvitok here: http://www.qlcplus.org/forum/viewtopic.php?f=5&t=8088&start=10#p42488

When creating a RGB matrix with generic dimmers, the bahaviour is not correct, as all the heads go to 100% intensity.

This is because the RGB Matrix function doesn't handle properly the intensity channel. We need to add an extra check for generic dimmers.

@janosvitok janosvitok self-assigned this Apr 16, 2016
janosvitok added a commit to janosvitok/qlcplus that referenced this issue Nov 16, 2016
- for each head, compute separately master dimmer channel and per-head dimmer
- adjust all related code (especially 2D monitor)
- RGB Matrix: if there are no RGB/CMY channels for a head:
  - if there is a per-head dimmer channel, it is faded to color value
    of the RGB matrix cell and all other dimmers are set to full
    (if dimmer control is enabled)
  - if there is no per-head dimmer, master dimmer is faded
  - if there is only master dimmer, and you don't want to have it faded,
    don't add it to RGB matrix :)

Fixes mcallegari#827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants