Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong index in m_audioDevCombo. #1220

Merged
merged 2 commits into from Mar 31, 2020
Merged

Fix wrong index in m_audioDevCombo. #1220

merged 2 commits into from Mar 31, 2020

Conversation

sbenejam
Copy link
Contributor

Assuming that Default device has index = 0 in m_audioDevCombo, discovered devices are added now starting on index = 1.

sbenejam and others added 2 commits March 30, 2020 19:46
@mcallegari mcallegari merged commit 9d0e742 into mcallegari:master Mar 31, 2020
@mcallegari
Copy link
Owner

A genuine bug. Thanks!

@mcallegari
Copy link
Owner

@sbenejam
On a second thought, I think selIdx = 1 is not right though.
If only the default device is present (which is unlikely...but still), selIdx should be 0.
What do you think?

@sbenejam
Copy link
Contributor Author

sbenejam commented Mar 31, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants