-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing unittest_cmake.sh #1437
Conversation
|
@mcallegari You can review this PR anyway, I added the missing shell script file. |
Looks good, thanks
|
I think |
I think I found it. Please refer to this link |
@Itay-Lifshitz please wait, I'm working on it right now. |
OK, please let me know the updates when you push them. |
I just pushed. A debian package is created, but I'm not sure if it is a proper one. |
OK, will work on appimage. |
#1408
@mcallegari
engine/test/qlci18n
works.Because
qlci18n_fi_FI.ts_
is required for testingqlci18n
andqlci18n_fi_FI.ts
is required for compiling the target and now both are omitted from Git.Tested on my side and it looks like working when I manually added these 2 files.
make check
for Windows is missing in the todo list. Don't we need it anymore? It looks like that it was there in the original "qlc.pro" file.resources/fixtures/scripts/fixtures-tool.py
from#!/usr/bin/env python
to#!/usr/bin/env python3
, otherwise it did not work. Not sure if python3 is default in your develop environment.