Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing unittest_cmake.sh #1437

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Added missing unittest_cmake.sh #1437

merged 1 commit into from
Jul 21, 2023

Conversation

Itay-Lifshitz
Copy link
Contributor

@Itay-Lifshitz Itay-Lifshitz commented Jul 21, 2023

#1408
@mcallegari

  • I am not so clear how engine/test/qlci18n works.
    Because qlci18n_fi_FI.ts_ is required for testing qlci18n and qlci18n_fi_FI.ts is required for compiling the target and now both are omitted from Git.
    Tested on my side and it looks like working when I manually added these 2 files.
  • It looks like make check for Windows is missing in the todo list. Don't we need it anymore? It looks like that it was there in the original "qlc.pro" file.
  • I manually modified the 1st line of resources/fixtures/scripts/fixtures-tool.py from #!/usr/bin/env python to #!/usr/bin/env python3, otherwise it did not work. Not sure if python3 is default in your develop environment.

@coveralls
Copy link

Coverage Status

coverage: 28.053%. remained the same when pulling 33a72c4 on Itay-Lifshitz:cmakebuild into 7622175 on mcallegari:cmakebuild.

@mcallegari
Copy link
Owner

mcallegari commented Jul 21, 2023

@Itay-Lifshitz

  • there's never been test units on Windows. They're executed only on Linux which is the reference OS (that's why I insisted to have a build working there first)
  • i18n I'll check later what was the intention of that test
  • python we suggest to install python-is-python3 package
    Thanks

@Itay-Lifshitz
Copy link
Contributor Author

@mcallegari You can review this PR anyway, I added the missing shell script file.

@mcallegari mcallegari merged commit 1ed252a into mcallegari:cmakebuild Jul 21, 2023
6 of 7 checks passed
@mcallegari
Copy link
Owner

Looks good, thanks
Next is creating Debian package
See: https://karthikkalyanaraman.medium.com/creating-debian-packages-cmake-e519a0186e87
Seems like adding the following and using cpack will do the trick

SET(CPACK_GENERATOR "DEB")
SET(CPACK_DEBIAN_PACKAGE_MAINTAINER "KK") #required
INCLUDE(CPack)

@Itay-Lifshitz Itay-Lifshitz deleted the cmakebuild branch July 22, 2023 00:43
@Itay-Lifshitz
Copy link
Contributor Author

@mcallegari

  • I was wondering how the original create-deb.sh worked.
    It simply runs dpkg-buildpackage -rfakeroot -I.git --jobs=auto and then it compiles, tests, builds packages and signs automatically.
    Where are these operations defined?
  • And I also got the following error when I tried to build debian package using the old create-deb.sh. How can I solve it?
    image

@mcallegari
Copy link
Owner

I think dpkg-buildpackage recognized it was a qmake project and built it that way.
As I mentioned in my previous comment, with cmake we need to use cpack.
I'm gonna give it a try when I have some time

@Itay-Lifshitz
Copy link
Contributor Author

I think dpkg-buildpackage recognized it was a qmake project and built it that way. As I mentioned in my previous comment, with cmake we need to use cpack. I'm gonna give it a try when I have some time

I think I found it. Please refer to this link
It says Ubuntu is referring to debian directory when it is building a package.
Working on it now.

@mcallegari
Copy link
Owner

@Itay-Lifshitz please wait, I'm working on it right now.
I'll push some changes soon

@Itay-Lifshitz
Copy link
Contributor Author

@Itay-Lifshitz please wait, I'm working on it right now. I'll push some changes soon

OK, please let me know the updates when you push them.

@mcallegari
Copy link
Owner

mcallegari commented Jul 22, 2023

I just pushed. A debian package is created, but I'm not sure if it is a proper one.
I think dependencies need to be fixed.
You can work on AppImage creation if you want. It is basically a manual procedure done on a QLC+ installation on a specific folder. See
make INSTALL_ROOT=$TARGET_DIR install
in create-appimage.sh

@Itay-Lifshitz
Copy link
Contributor Author

OK, will work on appimage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants