Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake Coverage build #1444

Merged
merged 1 commit into from Jul 31, 2023
Merged

CMake Coverage build #1444

merged 1 commit into from Jul 31, 2023

Conversation

Itay-Lifshitz
Copy link
Contributor

@Itay-Lifshitz Itay-Lifshitz commented Jul 30, 2023 •
edited

#1408
@mcallegari I think I have done.
Tested on my side for both of QLCv4 and QLCv5.
Please review this PR and give me feedbacks.

@coveralls
Copy link

Coverage Status

coverage: 28.053%. remained the same when pulling c4d954e on Itay-Lifshitz:cmakebuild into 4011d79 on mcallegari:cmakebuild.

@mcallegari mcallegari merged commit 1c16674 into mcallegari:cmakebuild Jul 31, 2023
5 of 7 checks passed
@mcallegari
Copy link
Owner

It works, thanks 👍

@Itay-Lifshitz Itay-Lifshitz deleted the cmakebuild branch July 31, 2023 18:12
@Itay-Lifshitz
Copy link
Contributor Author

It works, thanks 👍

Great! What's next?
If you will work on MacOS, I guess I have nothing to do in CMake build.
By the way, you can test on Qt6 build, too, because it worked on my side.

@mcallegari
Copy link
Owner

@Itay-Lifshitz I left a couple of messages on the shared gmail chat.
Please check them out, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Itay-Lifshitz @coveralls @mcallegari