resources: add Eurolite LED PLL-480 CW/WW #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcallegari
requested changes
Dec 23, 2023
Add Eurolite LED PLL-480 CW/WW [1]. The names and description were taken from 40001895-Manual-119588-1.000-de_en.pdf [2]. This fixture definition has some shortcomings: 1. There is no type for floodlights, so ColorChanger is used. 2. There are no separate presets for warm and cold white. So both warm and cold white have to use the same preset. 3. The bulb colour temperature field does not allow specifying the color range 3200K - 5600K. So the lower warm white colour is specified. [1] https://www.steinigke.de/en/mpn40001895-eurolite-led-pll-480-cw-ww-panel.html [2] https://www.steinigke.de/download/40001895-Manual-119588-1.000-eurolite-led-pll-480-cw-ww-panel-de_en.pdf Signed-off-by: Benjamin Drung <bdrung@posteo.de>
bdrung
force-pushed
the
Eurolite-LED-PLL-480
branch
from
c40ac56
to
1022f93
Compare
|
Thanks. Addressed the comments. Where should I report those three points mentioned in commit message as feature request? |
|
You can report here: |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Eurolite LED PLL-480 CW/WW [1]. The names and description were taken from 40001895-Manual-119588-1.000-de_en.pdf [2]. This fixture definition has some shortcomings:
[1] https://www.steinigke.de/en/mpn40001895-eurolite-led-pll-480-cw-ww-panel.html
[2] https://www.steinigke.de/download/40001895-Manual-119588-1.000-eurolite-led-pll-480-cw-ww-panel-de_en.pdf