Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QLC+ 5: Add linear regression to BPM tapping #1503

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

Wazzledi
Copy link
Contributor

As described in forum thread https://www.qlcplus.org/forum/viewtopic.php?p=71374, I added the linear regression method used in QLC+ 4 to the BPM tapping functionality of QLC+ 5.

@coveralls
Copy link

coveralls commented Jan 11, 2024

Coverage Status

coverage: 32.012%. remained the same
when pulling 99e7437 on Wazzledi:master
into a3b44ae on mcallegari:master.

qmlui/qml/KeyPad.qml Outdated Show resolved Hide resolved
qmlui/qml/KeyPad.qml Outdated Show resolved Hide resolved
@mcallegari
Copy link
Owner

Hey, how about the Time edit tool too?
https://github.com/mcallegari/qlcplus/blob/master/qmlui/qml/TimeEditTool.qml

There's another time tapping

@Wazzledi
Copy link
Contributor Author

I totally forgot about this thing.
For that, I moved the algorithm in the TimeUtil.js and added it to the TimeEditTool.
While testing the TimeEditTool, I noticed that the Tap button is also shown when the chaser is set to beat.
Is that intended? Also, I dont see x/2 and 2x anymore to get half beat chasers.

@mcallegari
Copy link
Owner

mcallegari commented Jan 15, 2024

For that, I moved the algorithm in the TimeUtil.js and added it to the TimeEditTool.

Excellent. I would have done the same!

While testing the TimeEditTool, I noticed that the Tap button is also shown when the chaser is set to beat. Is that intended?

Nope. It's actually not needed

Also, I dont see x/2 and 2x anymore to get half beat chasers.

I guess you mean like Speed Dial? TimeEditTool is not meant to be a replacement for Speed Dial

@Wazzledi
Copy link
Contributor Author

Wazzledi commented Jan 15, 2024

I guess you mean like Speed Dial? TimeEditTool is not meant to be a replacement for Speed Dial

When editing the chaser step length with the TimeEditTool and the type is set to beat, I assumed the buttons x/2 and 2x, which are present in the code, should be visible.
If they are not intended to be visible, then just ignore this comment.

@mcallegari
Copy link
Owner

mcallegari commented Jan 16, 2024

They are visible on a Beat-based RGB Matrix

image

@mcallegari mcallegari merged commit ef39a1a into mcallegari:master Jan 16, 2024
4 of 7 checks passed
@mcallegari
Copy link
Owner

Many thanks for this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants