Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmlui VC "not implemented" widgets #1539

Merged
merged 9 commits into from
Apr 28, 2024

Conversation

hjtappe
Copy link
Contributor

@hjtappe hjtappe commented Mar 27, 2024

Would it make sense to implement a quick stub for the VC widgets which are currently missing to save confusion with users trying the pre-version of v5, such as https://www.qlcplus.org/forum/viewtopic.php?t=17142

The VC will then just display a "not implemented" inside a widget if it is loaded from an existing file or if it is added from the sidebar.

@coveralls
Copy link

Coverage Status

coverage: 32.082%. remained the same
when pulling 39ad701 on hjtappe:qmlui-vc-not-implemented
into 1775f22 on mcallegari:master.

@yestalgia
Copy link
Sponsor Contributor

Nice idea

@mcallegari
Copy link
Owner

Excellent code contribution, thanks 👍
Next preliminary thing to do is to make sure load/save doesn't lose information on an existing project.
I'll start adding some code too

@mcallegari mcallegari merged commit a4052b9 into mcallegari:master Apr 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants