New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI scaling improvements #1553
UI scaling improvements #1553
Conversation
@@ -30,13 +30,17 @@ Rectangle | |||
anchors.fill: parent | |||
color: "transparent" | |||
|
|||
property real origItemHeight: UISettings.listItemHeight | |||
property real origIconMedium: UISettings.iconSizeMedium | |||
property real origItemHeight: { origItemHeight = UISettings.listItemHeight } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this syntax makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This syntax is meant to prevent a binding from being created on origItemHeight.
To my knowledge this is the cleanest way to do this inline, although I'm open to being wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I've never seen that syntax before.
I'll merge this as it is. Thanks
Hey, thanks for this. |
Fix general UI scaling bugs including
Current (Beat generator panel has been scaled up, then returned to smaller size):
Pull Request: