Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in Fixture Search #1560

Merged
merged 6 commits into from
May 14, 2024

Conversation

lilyCalla
Copy link
Contributor

Bugs fixed:

  • selecting or deselecting a fixture with Fixture Groups panel open results in a segfault
  • Escape erases the names of fixtures and universes
  • Switching from Fixture Groups view to another view in the left panel and then switching back to fixture view does not clear filter until the search button is clicked again, without any visual indication that a filter is still active

@coveralls
Copy link

coveralls commented May 1, 2024

Coverage Status

coverage: 32.068%. remained the same
when pulling 6bf200f on lilyCalla:fixture-select-segfault
into 3150b44 on mcallegari:master.

qmlui/treemodel.cpp Outdated Show resolved Hide resolved
qmlui/treemodel.cpp Outdated Show resolved Hide resolved
@lilyCalla
Copy link
Contributor Author

All stylistic issues resolved

@mcallegari
Copy link
Owner

I cannot reproduce the crash mentioned in the OP.
Can you please explain exactly how to reproduce it?

@lilyCalla
Copy link
Contributor Author

Ok sorry, forgot an important part of the crash.

Search for with a string that the filter you're about to click on does not match (such that it won't appear in the fixture group view). Then select it in the 2d view, and the application crashes

@mcallegari mcallegari merged commit 9aea2e7 into mcallegari:master May 14, 2024
7 checks passed
@mcallegari
Copy link
Owner

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants