New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCSlider: ignore fade in and fade out times #699
Conversation
This way sliders in playback mode have the same behavior as the sliders on a VCCueList. Start a function with a slider -> manual fade in. Stop a function with a slider -> manual fade out.
While this change is OK for me, my only concern is that it breaks the current behaviour. Also, if a Scene attached to a slider in playback mode has a 2 minutes fade in, I might want to set the slider to 80% and wait for 2 minutes until the Scene gets to 80% intensity. In other words, I'm afraid this change should be a new option. On existing projects the behaviour should be the existing one (to preserve backward compatibility), while on newly created Sliders, the new behaviour should be the default. As for the Cue List crossfaders behaviour, I don't remember who decided it (me ? you ?) but I suppose it should be consistent with the VCSlider default behaviour, thus "this change is OK for me" :) What do you think ? |
On a second thought...do we really need this change ? Can we just resolve this by placing a big bold message in the documentation like |
The VCSlider + fadeout time issue has to be fixed anyway. I have no solution to correctly take fadeout time into account on a VCSlider, except ignoring it totally. And since the fadeout time has to be ignored, the fadein time should be ignored too. Of course, ignoring fadein time on VCSliders could be an opt-in option. |
I totally agree in fixing the fade out issue. In general I believe QLC+ is starting to have too many options and it's starting to be difficult to understand each one of them and the learning curve becomes steeper and steeper. In QLC+ 5 I'm planning to have an "Advanced" section of parameters everywhere it is needed, to separate edgy features from the basic ones, that should be easily accessed even without reading the documentation (that people don't read anyway... 😆 ) |
At least we agree on one thing :)
This does not solve the fact that on a function with a fade in and a fade out time, controlling the function with a slider takes the fade in time into account, but not the fade out time. It could also be solved by having the function controlled by a button, with a submaster on the side.
The current PR does not make this an option, I just said it could be made as an option :) IMO having fade in but no fade out is broken, I wouldn't even allow it. I don't know what others think, it would be nice to have some more feedback on the forum. |
Yes, and that's exactly what I meant:
I think it's just a matter of explaining it properly in the documentation
Not necessarily (see above)
Then we should post the proposal in the Issues & feedbacks forum, cause not everyone watch the development forum |
I moved your proposal in issues and feedbacks |
Let's merge this. |
VCSlider: ignore fade in and fade out times
overrideSpeeds override outer speeds, not inner speeds -> the issue caused by mcallegari#699 is fixed
This way sliders in playback mode have the same behavior
as the sliders on a VCCueList.
Start a function with a slider -> manual fade in.
Stop a function with a slider -> manual fade out.
http://qlcplus.org/forum/viewtopic.php?f=12&t=9228