Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCSlider: ignore fade in and fade out times #699

Merged
merged 1 commit into from Dec 2, 2015

Conversation

plugz
Copy link
Contributor

@plugz plugz commented Nov 25, 2015

This way sliders in playback mode have the same behavior
as the sliders on a VCCueList.
Start a function with a slider -> manual fade in.
Stop a function with a slider -> manual fade out.

http://qlcplus.org/forum/viewtopic.php?f=12&t=9228

This way sliders in playback mode have the same behavior
as the sliders on a VCCueList.
Start a function with a slider -> manual fade in.
Stop a function with a slider -> manual fade out.
@mcallegari
Copy link
Owner

While this change is OK for me, my only concern is that it breaks the current behaviour.
There might be users with projects designed around the current behaviour and I guess they won't be happy about changing it.

Also, if a Scene attached to a slider in playback mode has a 2 minutes fade in, I might want to set the slider to 80% and wait for 2 minutes until the Scene gets to 80% intensity.
This might be a wanted behaviour.

In other words, I'm afraid this change should be a new option. On existing projects the behaviour should be the existing one (to preserve backward compatibility), while on newly created Sliders, the new behaviour should be the default.

As for the Cue List crossfaders behaviour, I don't remember who decided it (me ? you ?) but I suppose it should be consistent with the VCSlider default behaviour, thus "this change is OK for me" :)

What do you think ?

@mcallegari
Copy link
Owner

On a second thought...do we really need this change ?
I mean, if you attach a function with no fade in/out the VCSlider already takes full control of the function intensity.

Can we just resolve this by placing a big bold message in the documentation like
Note: if you want this slider to take full control over the attached Function intensity, then provide a Function with no Fade In and Fade Out times, so you will be able to manually perform fade in and fade out with the desired speed

@plugz
Copy link
Contributor Author

plugz commented Nov 26, 2015

The VCSlider + fadeout time issue has to be fixed anyway.
The current behavior for this is ugly. When you draw the slider down, the fadeout time is usually applied starting from a very low value.

I have no solution to correctly take fadeout time into account on a VCSlider, except ignoring it totally.

And since the fadeout time has to be ignored, the fadein time should be ignored too.
Bugs like "fade in works but fade out doesn't work" are sometimes reported, this would clear things out.

Of course, ignoring fadein time on VCSliders could be an opt-in option.
Ignoring fadeout time has to be done, because current behavior looks buggy.

@mcallegari
Copy link
Owner

I totally agree in fixing the fade out issue.
As for ignoring or not the fade in, well to be honest I remain of the opinion that it could be easily solved without touching the code, but just by providing a Function with or without fade in.

In general I believe QLC+ is starting to have too many options and it's starting to be difficult to understand each one of them and the learning curve becomes steeper and steeper.
If we can avoid adding more options, that would be great.

In QLC+ 5 I'm planning to have an "Advanced" section of parameters everywhere it is needed, to separate edgy features from the basic ones, that should be easily accessed even without reading the documentation (that people don't read anyway... 😆 )

@plugz
Copy link
Contributor Author

plugz commented Nov 27, 2015

I totally agree in fixing the fade out issue.

At least we agree on one thing :)

As for ignoring or not the fade in, well to be honest I remain of the opinion that it could be easily solved without touching the code, but just by providing a Function with or without fade in.

This does not solve the fact that on a function with a fade in and a fade out time, controlling the function with a slider takes the fade in time into account, but not the fade out time.

It could also be solved by having the function controlled by a button, with a submaster on the side.

In general I believe QLC+ is starting to have too many options and it's starting to be difficult to understand each one of them and the learning curve becomes steeper and steeper.
If we can avoid adding more options, that would be great.

In QLC+ 5 I'm planning to have an "Advanced" section of parameters everywhere it is needed, to separate edgy features from the basic ones, that should be easily accessed even without reading the documentation (that people don't read anyway... 😆 )

The current PR does not make this an option, I just said it could be made as an option :) IMO having fade in but no fade out is broken, I wouldn't even allow it. I don't know what others think, it would be nice to have some more feedback on the forum.

@mcallegari
Copy link
Owner

This does not solve the fact that on a function with a fade in and a fade out time, controlling the function with a slider takes the fade in time into account, but not the fade out time.

Yes, and that's exactly what I meant:

  • fade out is always ignored
  • if the Function has fade in, then see the case "2 minutes fade in & 80% intensity"
  • if the function doesn't have fade in, then the slider will have full control of the intensity

I think it's just a matter of explaining it properly in the documentation

The current PR does not make this an option, I just said it could be made as an option :) IMO having fade in but no fade out is broken, I wouldn't even allow it.

Not necessarily (see above)

I don't know what others think, it would be nice to have some more feedback on the forum.

Then we should post the proposal in the Issues & feedbacks forum, cause not everyone watch the development forum

@mcallegari
Copy link
Owner

I moved your proposal in issues and feedbacks

@mcallegari
Copy link
Owner

Let's merge this.
I'll update the documentation accordingly

mcallegari added a commit that referenced this pull request Dec 2, 2015
VCSlider: ignore fade in and fade out times
@mcallegari mcallegari merged commit e2663b9 into mcallegari:master Dec 2, 2015
@plugz plugz deleted the slider-nofade branch December 3, 2015 09:41
plugz added a commit to plugz/qlcplus that referenced this pull request May 19, 2017
overrideSpeeds override outer speeds, not inner speeds
-> the issue caused by mcallegari#699 is fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants