Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#761 Handle locales mapping when loading caches routes #763

Merged
merged 1 commit into from
Oct 24, 2021
Merged

#761 Handle locales mapping when loading caches routes #763

merged 1 commit into from
Oct 24, 2021

Conversation

jargoud
Copy link
Contributor

@jargoud jargoud commented Nov 19, 2020 •
edited
Loading

This fix intend to solve issue #761 when caching routes with locales mapping.

The current locale is mapped with configuration so that it will be mapped back if there's a match.

r0073rr0r
r0073rr0r approved these changes Dec 10, 2020
View reviewed changes
Copy link

@r0073rr0r r0073rr0r left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. can any1 merge this?

@iwasherefirst2
Copy link
Collaborator

I will try to look into it this week.

@iwasherefirst2
Copy link
Collaborator

Sorry it took me so long, I lost track of this one. @mcamara I think we should merge this. What do you think?

@mcamara mcamara merged commit 204c3ae into mcamara:master Oct 24, 2021
@iwasherefirst2 iwasherefirst2 mentioned this pull request Oct 24, 2021
Closed
@lsmith77
Copy link

lsmith77 commented Nov 5, 2021

hmm .. I am using 1.6.2 and I still get 404's when using artisan route:cache

@iwasherefirst2
Copy link
Collaborator

@lsmith77 route:cache won't work with this package. Instead, route:trans:cache shall be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizco dizco dizco approved these changes

@r0073rr0r r0073rr0r r0073rr0r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jargoud @iwasherefirst2 @lsmith77 @dizco @r0073rr0r @mcamara