Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about R^2 values in positive control linearity QC #48

Closed
neslihanky opened this issue Dec 21, 2023 · 3 comments · Fixed by #49
Closed

Question about R^2 values in positive control linearity QC #48

neslihanky opened this issue Dec 21, 2023 · 3 comments · Fixed by #49
Assignees

Comments

@neslihanky
Copy link

Hi,

Thank you for the great tool. I have a question on calculation of the positive control linearity QC. Based on NACHO's QC plot output and Nanostring's guide it should be "R^2 value". When I looked at the calculation function for this metric, it is actually calculating Pearson's correlation coefficient here . Just wanted to ask if you are aware of this or am I missing a point?

Thank you!

@mcanouil
Copy link
Owner

mcanouil commented Dec 26, 2023

I must say, I don't recall as it's from 4/5 years ago and I did not write all the code.

From the unit

"PCL" = '"(R^2)"',
it seems, the computation is indeed wrong.
I'll fix and release soon as CRAN is back after the holidays.
Thanks for the report!

@neslihanky
Copy link
Author

Thanks for the quick response on this!

@mcanouil
Copy link
Owner

mcanouil commented Jan 9, 2024

I should be able to make the release this week and should be available soon after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants