bug: Set the correct cache headers for static files #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache header values are currently passed as seconds instead of ms, which the library that
@fastify/static
uses expects (https://www.npmjs.com/package/send#maxage).You can pass a string value which is correctly parsed in the the right amount of ms.
There's another issue I've noticed, the
assetsBuildDirectory
files do not get handled by the stricter handler (with immutable).I've tried to set the prefix to
/build/
so they're correctly picked up, but I receive errors for double registration of routes then.Unsure how to properly resolve that issue.