Command prompt crashed

[sainnhe]

Describe the bug

cfb524ea5e1ecaa7c0eb0ab2fbb6675e298eb31d in master branch changed ^S to ^P to show the command prompt. And after I type ^P and execute a command, nnn.vim crashed.

To Reproduce

most minimal configuration:

if has('nvim')
    set runtimepath^=~/.vim runtimepath+=~/.vim/after
    let &packpath = &runtimepath
endif
call plug#begin('~/.cache/vim/plugins')
Plug 'mcchrish/nnn.vim'
call plug#end()

0. Compile and install nnn from master branch.
1. Open vim (or nvim)
2. Run command :NnnPicker
3. Press key ^P, type ls
4. See error

Expected behavior

After I execute ls, nnn.vim should continue to work.

Screenshots

Environment:

• OS: Arch Linux
• Terminal: GNOME Terminal 3.30.2 using VTE 0.54.3 +GNUTLS
• Shell: zsh 5.7.1 (x86_64-pc-linux-gnu)
• Vim version: neovim 0.3.4
• Plugin manager: vim-plug
• Plugin version: master
• Nnn version: 2.2 (compile from master branch)

Additional context

none.

[mcchrish]

I'm able to replicate it. It doesn't seem to work with non-login shells?

I'm using iTerm in macOS and another way to replicate the issue is passing nnn as command, as I assume it runs as a non-login shell. My knowledge on shell environment behaviors is currently limited so I might not able to help.

cc @jarun

[jarun]

@sainnhe are you saying ^S used to work but ^P has the issue?

I changed ^S to ^P because of jarun/nnn#200

[jarun]

OK, I see the UI breaks.

[jarun]

Please check if the issue is fixed with nnn master.

[mcchrish]

@jarun tested and works! 👍

[jarun]

Awesome! Now we are using the stock prompt instead of the libreadline one when nnn is started in file picker mode.

[sainnhe]

@jarun Thanks for your work!!

[jarun]

My pleasure!