Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard open_with getreadline for picker #1241

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Conversation

luukvbaal
Copy link
Collaborator

@luukvbaal luukvbaal commented Nov 23, 2021

Copied the guard already present in prompt_run() which I assume is there for the same reason.

fix luukvbaal/nnn.nvim#25

Edit: Yeah looked through git blame to find the original relevant issue: mcchrish/nnn.vim#39.

@jarun
Copy link
Owner

jarun commented Nov 23, 2021

This is because we exit the curses mode when we call getreadline(). We can't do that when we are inside a plugin e.g the (n)vim plugins.

@jarun jarun merged commit 2f98625 into jarun:master Nov 23, 2021
@jarun
Copy link
Owner

jarun commented Nov 23, 2021

Thank you!

@luukvbaal
Copy link
Collaborator Author

This is because we exit the curses mode when we call getreadline(). We can't do that when we are inside a plugin e.g the (n)vim plugins.

Yeah I figured exitcurses() was the issue here. Although the issue was present for picker mode in general (i.e. nnn -p - in terminal), not just inside the plugins. Guess the underlying reason is just the picker mode redirection.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Open file can not return to nnn
2 participants