Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI.begin() variants #37

Closed
vshymanskyy opened this issue Dec 6, 2017 · 5 comments
Closed

SPI.begin() variants #37

vshymanskyy opened this issue Dec 6, 2017 · 5 comments

Comments

@vshymanskyy
Copy link

On some boards, SPI.begin() is used to set SPI pins:

SPI.begin(5,19,27,18);

Currently, this is hardcoded in the library, but it may be best to leave it for the user sketch.
https://www.thethingsnetwork.org/forum/t/big-esp32-sx127x-topic/10247/131

@terrillmoore
Copy link
Member

terrillmoore commented Dec 6, 2017 via email

@cyberman54
Copy link

@terrillmoore I could need this, too, for my paxcounter software which supports generic boards.

@cyberman54
Copy link

Suggested implemenation with pull request #157

@terrillmoore
Copy link
Member

Unfortunately, I discovered that my suggestion of adding to the pinmap can't work on Adafruit BSPs. Sigh. Plus (after suggesting that) I learned that changing the pinmap can be a major breaking change. See my comments on #157.

@terrillmoore
Copy link
Member

This is closed by #190.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants