Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit reply w/o ACK to confirmed uplink is not handled #382

Closed
terrillmoore opened this issue Aug 23, 2019 · 1 comment
Closed

Explicit reply w/o ACK to confirmed uplink is not handled #382

terrillmoore opened this issue Aug 23, 2019 · 1 comment
Assignees
Labels

Comments

@terrillmoore
Copy link
Member

The latest EU compliance tests check the following.

  1. Device issues a confirmed uplink
  2. network replies with a downlink in RX1 or RX2 but FHDR.FCtrl.ACK bit is reset
  3. device is supposed to notice that ACK is not set, and retransmit.

In fact, LMIC just assumes that a valid downlink was an ACK. That's probably a reasonable assumption, but it's not compliant with the spec.

Apart from this, the LMIC passes the entire EU V1.5 test, except for the optional data rates.

@terrillmoore terrillmoore self-assigned this Aug 23, 2019
@terrillmoore terrillmoore added this to To do in Pass pre-compliance tests via automation Aug 23, 2019
@terrillmoore
Copy link
Member Author

terrillmoore commented Aug 23, 2019

While fixing this, we should also do #238, because otherwise this will involve adding yet another goto to processDnData(). Since the goto's end up expressing pure tail-recursion rather than iteration, any compiler is going to generate pretty much the same code anyway.

Pass pre-compliance tests automation moved this from To do to Done Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

1 participant