Allow configuring maximum frame length more precisely #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecates the `LMIC_ENABLE_long_messages` configuration macro and allows configuring LMIC_MAX_FRAME_LENGTH instead, allowing a more fine-grained balance between memory usage and maximum frame length.
matthijskooijman
force-pushed
the
max-frame-length
branch
from
d7b9367
to
9455a6c
Compare
|
I agree, we can change this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the
LMIC_ENABLE_long_messagesconfiguration macro andallows configuring LMIC_MAX_FRAME_LENGTH instead, allowing a more
fine-grained balance between memory usage and maximum frame length.
I originally started this because I was a bit confused with the documentation for
LMIC_ENABLE_long_messages(it wasn't entirely clear what the default setting was), but while rewriting the README entry about this, I realized it was weird that you could only choose between two maximum sizes, when there's no technical reason (that I could see) to limit this to specific values (other than that the value should not be too small).