Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit nested transactions when exiting the context #58

Conversation

o-fedorov
Copy link
Contributor

This change is required for PostgreSQL, I tested it with version 11.

Without a commit statement, nested transactions are silently rolled back, the behavior is quite surprising.

@o-fedorov
Copy link
Contributor Author

Also, could not cover the change with tests, since the tests are written for SQLite only. Please tell me if you would like me to still add tests and perhaps provide CI configuration for PostgreSQL.

@mcfunley
Copy link
Owner

I added support for postgres in the test suite, and committed these changes here:
5c16c6a

And I added some test coverage for this here:
d43de3a

Thank you! Will cut a release shortly.

@mcfunley mcfunley closed this Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants