Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit nested transactions when exiting the context #58

Closed
wants to merge 1 commit into from
Closed

Commit nested transactions when exiting the context #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion pugsql/compiler.py
View file
Open in desktop
Expand Up @@ -3,11 +3,12 @@
"""
from . import parser, context
from .exceptions import NoConnectionError
from contextlib import contextmanager
from contextlib import contextmanager, suppress
from glob import glob
import os
from sqlalchemy import create_engine
from sqlalchemy.orm import sessionmaker
from sqlalchemy.exc import ResourceClosedError
import threading
import re

Expand Down Expand Up @@ -127,6 +128,9 @@ def transaction(self):
except Exception as e:
session.rollback()
raise e
else:
with suppress(ResourceClosedError):
session.commit()

def _execute(self, clause, *multiparams, **params):
if getattr(self._locals, 'session', None):
Expand Down