Added alterative calendar support through netcdftime #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 74.94% 75.13% +0.19%
==========================================
Files 14 15 +1
Lines 1257 1283 +26
==========================================
+ Hits 942 964 +22
- Misses 315 319 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that netcdftime has the support we need for alternative calendars. I would just tell users to use its objects, but it feels like it's missing a unified interface for creating objects with different calendars (
netcdftime.datetimeis justnetcdftime.DatetimeProlepticGregorian), so I made one. It uses the standard Python datetime for the proleptic Gregorian calendar, and attempts to usenetcdftimefor other calendars. Ifnetcdftimeis not installed, it complains to the user. I also updated the documentation with all of this info. I only included basic tests for the datetimes, since these are extensively tested innetcdftime.