Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Unable to (de)normalize an array of values #1

Closed
edcarroll opened this issue Jul 17, 2017 · 4 comments
Closed

bug: Unable to (de)normalize an array of values #1

edcarroll opened this issue Jul 17, 2017 · 4 comments
Assignees

Comments

@edcarroll
Copy link
Contributor

Hi there,

Love the project, always a fan of using decorators to avoid extra schema definitions everywhere!

Ran into an issue though, I can't work out how to (de)normalize to and from an array of values. In normalizr you just wrap the schema in [], however I've dug through your source and cannot find a way to do it.

Are you able to please advise? Thanks!

@edcarroll
Copy link
Contributor Author

Ended up making a PR to address the issue raised, let me know your thoughts 😄

@mchlbrnd
Copy link
Owner

Sweet! Thanks @edcarroll! Let me review the PR. I'll add the necessary documentation changes.

What are you ideas regarding implementing the missing schema types? I'll add some issues for these as well.

Cheers,
Michael

PS. sorry for the late reply!

@edcarroll
Copy link
Contributor Author

Hey @mchlbrnd, no worries, thank you for getting back to me 😄

So I ended up adding a few things forgetting there was a PR on my fork, so let me know if there's anything in there you don't like.

Hadn't yet thought about adding the other types yet, was basically adding functionality as I ran into it. Will be able to come back to this in a few days though (I hope) with some ideas 😄

@mchlbrnd
Copy link
Owner

I just added some more issues. No worries about the additional stuff in the PR. It is very welcome!

mchlbrnd pushed a commit that referenced this issue Aug 14, 2017
- Fixes #1 
- Adds tests
- Adds contributors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants