fix: Added support for Array schema #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchlbrnd
reviewed
Aug 14, 2017
mchlbrnd
approved these changes
Aug 14, 2017
mchlbrnd
approved these changes
Aug 14, 2017
mchlbrnd
approved these changes
Aug 14, 2017
mchlbrnd
approved these changes
Aug 14, 2017
mchlbrnd
approved these changes
Aug 14, 2017
mchlbrnd
approved these changes
Aug 14, 2017
mchlbrnd
approved these changes
Aug 14, 2017
mchlbrnd
approved these changes
Aug 14, 2017
|
Are you meaning shrinkwrap vs package-lock? As far as I'm aware package-lock.json is essentially a new version of the shrinkwrap functionality, but is a bit easier to use as it just works with |
mchlbrnd
approved these changes
Aug 14, 2017
mchlbrnd
approved these changes
Aug 14, 2017
mchlbrnd
approved these changes
Aug 14, 2017
|
btw, are you meaning to re-approve the PR so much? 😛 |
mchlbrnd
approved these changes
Aug 14, 2017
|
Ha, I was looking at the review functionality in GitHub. :P |
|
Fair enough! lmk if you want me to change anything |
mchlbrnd
reviewed
Aug 14, 2017
There was a problem hiding this comment.
@edcarroll add yourself to package.json authors and revert the name.
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "normalizr-decorators", | |||
| "version": "1.0.0-alpha.1", | |||
| "name": "@edcarroll/normalizr-decorators", | |||
package.json
Outdated
| "name": "normalizr-decorators", | ||
| "version": "1.0.0-alpha.1", | ||
| "name": "@edcarroll/normalizr-decorators", | ||
| "version": "1.0.0-alpha.5", | ||
| "description": "Schema decorators for normalizr", | ||
| "author": "Michael Wolbert <michael.wolbert@gmail.com>", |
mchlbrnd
approved these changes
Aug 14, 2017
Add Edward Carroll
|
Thank you for sorting that 🎉 currently underwater with a work project, but should be wrapped up on Thursday so will be able to take a look at & have a chat about some of the other issues 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
This PR also addresses various other things within the project, like tests & ensuring that the typings are found correctly, as well as removing compiled files from the repo.