Use standard processor macros #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous macros used were core specific and caused compiling for these processors to fail when a core that didn't define them was used.
Merged
|
I do not see this merge in the master... Still having the problem on attiny85 |
|
@bodtx the problem you're encountering was caused by a regression introduced in 18d6cb8. I should have this fixed in #33. I'd appreciate if you would give it a test and let me know if it works/doesn't work for you. You can download my fixed version of the library at https://github.com/per1234/arduino-libs-manchester/archive/fix-processor-macro-regression.zip. |
|
I've tested just right now and this zipped library is working 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous macros used were core specific and caused compiling for
these processors to fail when a core(such as https://github.com/damellis/attiny) that didn't define them was used.
closes #13