Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added directory support #32

Merged
merged 2 commits into from Jan 16, 2017
Merged

Added directory support #32

merged 2 commits into from Jan 16, 2017

Conversation

thorgeir
Copy link
Contributor

@thorgeir thorgeir commented Jan 3, 2017

No description provided.

Added support for common version-number-naming-conventions in filenames
get
{
return Files;
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this return Files.Contat(Directories)? A more general question - does this PR work with nested directories (I don't think you explicitly mentioned it, but I notice the test folder is a single directory)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should, but I did not implement sub-directories, so I left it out.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are subdirectories unnecessary for ASP.NET bundling, or will embedded resource bundling only work with single subdirectories?

Sorry for dumb questions but I don't use Bundles that much, and if there's any unexpected behaviour I'll need to document it to reduce the number of people raising Github Issues.

@@ -7,7 +7,7 @@
<title></title>
<script src="/alert.js" type="text/javascript"></script>
<script src="/alert2.js" type="text/javascript"></script>
<script src="/Scripts/alert.3.js" type="text/javascript"></script>
<script src="/Scripts/alert-1.12.34567.min.js" type="text/javascript"></script>
<script src="/3rd3Party/3select2-3.4.5/select2.js" type="text/javascript"></script>
<script src="/3rd3Party/hammer.js-1.0.10/hammer.js" type="text/javascript"></script>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/3rd3Party/3select2-3.4.5/select2.js looks pretty tricky - does it work ok with the regex? (sorry I don't have access to VS to test this stuff out)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it works, Demo

@mcintyre321 mcintyre321 merged commit 550dbaf into mcintyre321:master Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants