Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade werkzeug from 2.2.3 to 3.0.1 #128

Merged
merged 7 commits into from
Nov 2, 2023

Conversation

Joseph-Perkins
Copy link
Contributor

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • vizro-core/snyk/requirements.txt
⚠️ Warning
pandas 1.3.5 requires numpy, which is not installed.
kedro 0.18.14 has requirement importlib-metadata<5.0,>=3.6; python_version < "3.8", but you have importlib-metadata 6.7.0.

Vulnerabilities that will be fixed

By pinning:
Severity Issue Upgrade Breaking Change Exploit Maturity
medium severity Inefficient Algorithmic Complexity
SNYK-PYTHON-WERKZEUG-6035177
werkzeug:
2.2.3 -> 3.0.1
No No Known Exploit

Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-WERKZEUG-6035177
@huong-li-nguyen
Copy link
Contributor

huong-li-nguyen commented Oct 26, 2023

I don't think this is possible for us to resolve right now @lingyielia @Joseph-Perkins. Even the latest dash version requires werkzeug<2.3.0

See these PRs and open issues for reference:
plotly/dash#2538
plotly/dash#2614

Can we get an exemption for this one?

@huong-li-nguyen
Copy link
Contributor

@lingyielia - did we talk with the infosec team about this yet, such that we can close the PR?

@lingyielia
Copy link
Contributor

@lingyielia - did we talk with the infosec team about this yet, such that we can close the PR?

We are still waiting for the response. Will address this pr as soon as the next step is clear

@lingyielia lingyielia added Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed dependencies and removed Status: Won't fix labels Nov 2, 2023
@lingyielia
Copy link
Contributor

Upgrade feasible now: plotly/dash#2674

@lingyielia lingyielia merged commit cc0952d into main Nov 2, 2023
30 checks passed
@lingyielia lingyielia deleted the snyk-fix-1fa4e2ea1b51a679b7318abdba0b4f36 branch November 2, 2023 18:01
@lingyielia lingyielia mentioned this pull request Dec 11, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants