Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dash lower bound to 2.14.1 #203

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Bump dash lower bound to 2.14.1 #203

merged 2 commits into from
Dec 12, 2023

Conversation

lingyielia
Copy link
Contributor

@lingyielia lingyielia commented Dec 8, 2023

Description

This bump is required by a chain of dependency upgrade.

Screenshot

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Copy link
Contributor

@huong-li-nguyen huong-li-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lingyielia , could you just add a link to the PR description why we need to raise the lower bound? e.g. is this for us to be compatible with the latest werkzeug version? Is the latest werkzeug version required for deployment?

@lingyielia
Copy link
Contributor Author

@lingyielia , could you just add a link to the PR description why we need to raise the lower bound? e.g. is this for us to be compatible with the latest werkzeug version? Is the latest werkzeug version required for deployment?

Thanks for reviewing! Just added the description

Copy link
Contributor

@huong-li-nguyen huong-li-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR description - helps to understand now 👍

Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for adding PR description

@lingyielia lingyielia added Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed dependencies Pull requests that update a dependency file labels Dec 12, 2023
@lingyielia lingyielia merged commit ace6a1f into main Dec 12, 2023
33 checks passed
@lingyielia lingyielia deleted the fix/dash_lowerbound branch December 12, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants