Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Ignore unexpected query parameters rather than raising an exception #539

Merged
merged 10 commits into from
Jun 21, 2024
Merged

[Bug] Ignore unexpected query parameters rather than raising an exception #539

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
39b770d
Ignored unexpected query parameters rather than raising an exception
antonymilne Jun 19, 2024
9b4a0de
Add changelog
antonymilne Jun 19, 2024
8224a0a
Merge branch 'main' into bug/query-parameters
antonymilne Jun 19, 2024
3ee8148
Update vizro-core/changelog.d/20240618_120925_antony.milne_strict_che…
antonymilne Jun 19, 2024
f283d27
Add test and check it fails
antonymilne Jun 19, 2024
9201a2d
Add test and check it fails
antonymilne Jun 19, 2024
277a154
It does fail, so now page it pass
antonymilne Jun 19, 2024
1459c50
Merge branch 'main' of https://github.com/mckinsey/vizro into bug/que…
l0uden Jun 20, 2024
9670843
change integration tests and chromedrvier version
l0uden Jun 20, 2024
96c0f14
change chromedrvier version
l0uden Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions vizro-core/changelog.d/20240618_120925_antony.milne_strict_checks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<!--
A new scriv changelog fragment.

Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Highlights ✨

- A bullet item for the Highlights ✨ category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Removed

- A bullet item for the Removed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Added

- A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Changed

- A bullet item for the Changed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Deprecated

- A bullet item for the Deprecated category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->

### Fixed

- Ignored unexpected query parameters rather than raising an exception ([#539](https://github.com/mckinsey/vizro/pull/539))
antonymilne marked this conversation as resolved.
Show resolved Hide resolved

<!--
### Security

- A bullet item for the Security category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
2 changes: 1 addition & 1 deletion vizro-core/src/vizro/models/_dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ def _arrange_page_divs(self, page_divs: _PageDivsType):
page_main = html.Div(id="page-main", children=[collapsable_left_side, collapsable_icon, right_side])
return html.Div(children=[page_header, page_main], className="page-container")

def _make_page_layout(self, page: Page):
def _make_page_layout(self, page: Page, **kwargs):
page_divs = self._get_page_divs(page=page)
page_layout = self._arrange_page_divs(page_divs=page_divs)
page_layout.id = page.id
Expand Down
Loading