-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Ignore unexpected query parameters rather than raising an exception #539
Conversation
vizro-core/changelog.d/20240618_120925_antony.milne_strict_checks.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Not sure why my new integration test isn't work well... We might need to move this to your QA tests instead @l0uden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I'll write in |
Description
Before
Going to http://localhost:8050/?species=virginica would raise error:
This was kind of a bug and kind of expected behaviour that we just didn't care about.
Now
The query parameter is just ignored.
This is the solution recommended in https://github.com/AnnMarieW/dash-multi-page-app-demos/?tab=readme-ov-file#5-preventing-query-string-errors. it doesn't prevent us from using query parameters in the future (very likely to do so) and is consistent with behaviour if
layout
is no longer a function at some point in the future (not so likely).Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":