Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency from vizro_ai #544

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

lingyielia
Copy link
Contributor

@lingyielia lingyielia commented Jun 22, 2024

Description

langchain is not dependent on langchain-community anymore since v0.2, and langchain-community is not a dependency of vizro_ai.

langchain-ai/langchain#19083

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@lingyielia lingyielia marked this pull request as ready for review June 22, 2024 01:07
@lingyielia lingyielia self-assigned this Jun 22, 2024
@lingyielia lingyielia added Status: Ready for Review ☑️ Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package labels Jun 22, 2024
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lingyielia lingyielia merged commit f81b55d into main Jun 24, 2024
39 checks passed
@lingyielia lingyielia deleted the tidy/remove_langchain_community branch June 24, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants