Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Update LLM model wrapper mapping #517

Merged
merged 7 commits into from
Jul 5, 2024
Merged

[Dev] Update LLM model wrapper mapping #517

merged 7 commits into from
Jul 5, 2024

Conversation

Anna-Xiong
Copy link
Contributor

@Anna-Xiong Anna-Xiong commented Jun 6, 2024

Description

Update:

  1. We decided to merge this one first to update the model allow mechanism per our discussion @maxschulz-COL @lingyielia
    2.We need to continue track the AzureOpenAI issues from langchain repo

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@Anna-Xiong Anna-Xiong added the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Jun 7, 2024
@huong-li-nguyen huong-li-nguyen changed the title [Bug] allow Azure OpenAI and other models [Bug] Allow Azure OpenAI and other models Jun 18, 2024
@Anna-Xiong Anna-Xiong changed the title [Bug] Allow Azure OpenAI and other models [Dev] Update LLM model wrapper mapping Jun 26, 2024
Copy link
Contributor

@lingyielia lingyielia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement! Approved with 2 comments.

vizro-ai/src/vizro_ai/chains/_llm_models.py Outdated Show resolved Hide resolved
@Anna-Xiong
Copy link
Contributor Author

Hi @lingyielia @maxschulz-COL
is this still relevant given the new update in main branch? #544

@lingyielia
Copy link
Contributor

These 2 PRs are different. #544 is removing langchain_community.

@Anna-Xiong
Copy link
Contributor Author

These 2 PRs are different. #544 is removing langchain_community.

sorry the link of the pull request was copied wrong, it is #550

@maxschulz-COL
Copy link
Contributor

Hi @lingyielia @maxschulz-COL is this still relevant given the new update in main branch? #544

Can we discuss this in our catch-up this afternoon? Just to remind everyone what is going on?

@lingyielia lingyielia merged commit 542b4c1 into main Jul 5, 2024
36 checks passed
@lingyielia lingyielia deleted the bug/azure_openai branch July 5, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants