Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce validator to raise ModuleNotFoundError at dashboard creation #97

Merged
merged 11 commits into from
Oct 6, 2023
Merged

Introduce validator to raise ModuleNotFoundError at dashboard creation #97

merged 11 commits into from
Oct 6, 2023

Conversation

maxschulz-COL
Copy link
Contributor

@maxschulz-COL maxschulz-COL commented Oct 5, 2023 •
edited

Description

Screenshot

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added the PR number to the change description in the changelog fragment, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1)) (if applicable)
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@maxschulz-COL maxschulz-COL linked an issue Oct 5, 2023 that may be closed by this pull request
Absence of openpyxl library causes console errors #86
Closed
1 task
@maxschulz-COL maxschulz-COL added Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed Component: Configuration 💻 Issue/PR that addresses changes in the configuration (public API) Issue: Bug Report 🐛 Issue/PR that report/fix a bug labels Oct 5, 2023
@maxschulz-COL maxschulz-COL marked this pull request as ready for review October 5, 2023 13:02
chiara-sophie
chiara-sophie reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@chiara-sophie chiara-sophie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 Just an idea on how I would rewrite the Error message.

vizro-core/src/vizro/models/_action/_action.py Outdated Show resolved Hide resolved
@petar-qb
Copy link
Contributor

petar-qb commented Oct 5, 2023

The link from the PR Description is wrong, so can you just update it? 😄.

antonymilne
antonymilne reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Just a couple of fussy comments/questions, but I'm sure we can get this merged soon 🙂

vizro-core/src/vizro/models/_action/_action.py Outdated Show resolved Hide resolved
vizro-core/src/vizro/models/_action/_action.py Outdated Show resolved Hide resolved
....d/20231005_145819_maximilian_schulz_86_absence_of_openpyxl_library_causes_console_errors.md Outdated Show resolved Hide resolved
maxschulz-COL and others added 3 commits October 6, 2023 08:56
@maxschulz-COL @antonymilne
Update vizro-core/changelog.d/20231005_145819_maximilian_schulz_86_ab…
8e3978e 
…sence_of_openpyxl_library_causes_console_errors.md

Co-authored-by: Antony Milne <49395058+antonymilne@users.noreply.github.com>
Signed-off-by: Maximilian Schulz <83698606+maxschulz-COL@users.noreply.github.com>
@maxschulz-COL @antonymilne
Update vizro-core/src/vizro/models/_action/_action.py
9ca7f17 
Co-authored-by: Antony Milne <49395058+antonymilne@users.noreply.github.com>
Signed-off-by: Maximilian Schulz <83698606+maxschulz-COL@users.noreply.github.com>
@maxschulz-COL
Merge branch 'main' into 86-absence-of-openpyxl-library-causes-consol…
994bb61 
…e-errors
l0uden
l0uden approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@l0uden l0uden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!
Tested it.
Approve from my side.

antonymilne
antonymilne approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion but looks good 👍

vizro-core/src/vizro/models/_action/_action.py Outdated Show resolved Hide resolved
@maxschulz-COL maxschulz-COL merged commit 0cbe19f into main Oct 6, 2023
25 checks passed
@maxschulz-COL maxschulz-COL deleted the 86-absence-of-openpyxl-library-causes-console-errors branch October 6, 2023 15:55
@antonymilne antonymilne mentioned this pull request Oct 9, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonymilne antonymilne antonymilne approved these changes

@petar-qb petar-qb petar-qb approved these changes

@l0uden l0uden l0uden approved these changes

@lingyielia lingyielia Awaiting requested review from lingyielia

@huong-li-nguyen huong-li-nguyen Awaiting requested review from huong-li-nguyen huong-li-nguyen is a code owner

@Joseph-Perkins Joseph-Perkins Awaiting requested review from Joseph-Perkins Joseph-Perkins is a code owner

@chiara-sophie chiara-sophie Awaiting requested review from chiara-sophie

Assignees

@maxschulz-COL maxschulz-COL

Labels
Component: Configuration 💻 Issue/PR that addresses changes in the configuration (public API) Issue: Bug Report 🐛 Issue/PR that report/fix a bug Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Absence of openpyxl library causes console errors
5 participants
@maxschulz-COL @petar-qb @l0uden @antonymilne @chiara-sophie