Fix match_array to truly accept non-array #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was noticed that `match_array` raised an error when given a single, non-array argument as opposed to an array (which is the documented usage). An attempt was made to fix this; however, the conditional added to `match_array` only checked that the single argument was a string. This commit matches the original implementation of `match_array` by accepting any type of non-array, not just a string. Co-authored-by: wata_mac <watassbass@gmail.com>
mcmire
force-pushed
the
splat-match-array-args
branch
from
2974762
to
9465e9f
Compare
mcmire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was noticed that
match_arrayraised an error when given a single, non-array argument as opposed to an array (which is the documented usage). An attempt was made to fix this; however, the conditional added tomatch_arrayonly checked that the single argument was a string. This commit matches the original implementation ofmatch_arrayby accepting any type of non-array, not just a string.Also see: #97
Recreation of: #135 (hat tip: @wata727)