Fix an error when passed non-array to match_array

[wata727]

Fixes #132

This issue is caused by a difference in handling arguments to the monkey patched match_array. In the original matcher implementation, the arguments are splatted:

https://github.com/rspec/rspec-expectations/blob/040d1b0bba83031c9ae432fd3a4462fdd1cc74e7/lib/rspec/matchers.rb#L715-L717
https://github.com/rspec/rspec-expectations/blob/040d1b0bba83031c9ae432fd3a4462fdd1cc74e7/lib/rspec/matchers.rb#L510-L512

[anmolarora]

Shouldn't this be?

Suggested change

	items = *items
	BuiltIn::MatchArray.new(items)
	BuiltIn::MatchArray.new(items.is_a?(Array) ? items : [items] )

[wata727]

The original implementation is splatting the given argument, so I believe it would be more strict to do the same conversion.
https://github.com/rspec/rspec-expectations/blob/040d1b0bba83031c9ae432fd3a4462fdd1cc74e7/lib/rspec/matchers.rb#L715-L717

[anmolarora]

👍🏼

[mcmire]

Good call!

[mcmire]

Hi @wata727, sorry it has taken me so long to get to this PR. I took a closer look at the current behavior of match_array. It looks like it doesn't matter what you pass to match_array — if you pass a single non-array, then it should treat it as it though you pass it an array with that single value. It also looks like that issue was raised in #97 and a fix was attempted in #110, but I must have misunderstood that it doesn't matter whether the value is a string, an rspec-mocks argument matcher, a hash, or whatever — just as long as it's not an array. I rebased this PR and removed the extra tests you added. It makes sense that we'd want to prove that match_array can take a non-array; but I think the existing tests already did this, although perhaps we should have used something that clearly cannot be turned into an array on its own, and the test name also didn't spell this out. I made some adjustments and merged #213 and gave you credit. Thank you!

[mcmire]

This fix has been included in v0.11.0. Thanks again!