Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the use of primary keys other than "id" in ActiveRecord. #237

Commits on Apr 1, 2024

  1. Support the use of primary keys other than "id" in ActiveRecord.

    Previously the diffing code made an assumption that "id" would always be
    the primary field. This is not always the case. Additionally, the use of
    read_attribute(:id) is deprecated in rails/rails@39997a0.
    
    This changes adds support for use of custom primary key fields, and
    updates the Person test model to use the "person_id" primary key.
    
    Note that this will almost certainly still run into issues if the model
    uses the newly introduced composite primary key type, so this would
    require additional changes outside the scope of this fix.
    benk-gc committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    7ffc318 View commit details
    Browse the repository at this point in the history