feat: add setupRequest per request for requests array #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
Since the
setupClient
appears to mutate theClient
classs located inhttpClient.js
, I decided to add the ability to mutate each request independently within therequests
array if it is provided.I thought about using the
setupClient
property at first, but it appears that each request in therequests
array is passed to theRequestIterator
and is never constructed as aClient
presumably for performance reasons. For this purpose, I decided to name a new property calledsetupRequest
that mutates the raw request object.I have added corresponding tests, documentation and have followed the code style in autocannon. I hope this is a meaningful addition, as I myself did require this functionality in one of my projects where I tested the creation of entities and their subsequent mutation via a url param.
Please let me know if I should change anything in the PR to match your expectations.